Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #43946 from jhorwit2/jah/host-path-psp" #47851

Merged
merged 1 commit into from
Jun 21, 2017
Merged

Revert "Merge pull request #43946 from jhorwit2/jah/host-path-psp" #47851

merged 1 commit into from
Jun 21, 2017

Conversation

jhorwit2
Copy link
Contributor

@jhorwit2 jhorwit2 commented Jun 21, 2017 •
edited by liggitt

fixes #47863

This reverts commit b5eadb5, reversing
changes made to 1889d65.

What this PR does / why we need it:

Revert whitelist host paths in psp due to API concerns. Please refer to #47811 for the concerns.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

cc @liggitt @ericchiang @smarterclayton

Release note:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 21, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @jhorwit2. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Jun 21, 2017
@liggitt liggitt added this to the v1.7 milestone Jun 21, 2017
@liggitt
Copy link
Member

liggitt commented Jun 21, 2017

looks like you're missing generated files from the original PR, please run hack/update-all.sh and update

@jhorwit2 jhorwit2 force-pushed the jah/revert-psp-hostpath-whitelist branch from 83f6960 to 799679f Compare June 21, 2017 16:20
@jhorwit2
Revert "Merge pull request kubernetes#43946 from jhorwit2/jah/host-pa…
b6e08ec 
…th-psp"

This reverts commit b5eadb5, reversing
changes made to 1889d65.
@ericchiang
Copy link
Contributor

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 21, 2017
@jhorwit2 jhorwit2 force-pushed the jah/revert-psp-hostpath-whitelist branch from 799679f to b6e08ec Compare June 21, 2017 16:45
@liggitt liggitt mentioned this pull request Jun 21, 2017
Merged
@liggitt
Copy link
Member

liggitt commented Jun 21, 2017

@kubernetes/sig-auth-api-reviews @kubernetes/api-reviewers

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jun 21, 2017
@rootfs
Copy link
Contributor

rootfs commented Jun 21, 2017

/assign @liggitt
/unassign

@k8s-ci-robot k8s-ci-robot assigned liggitt and unassigned rootfs Jun 21, 2017
@liggitt
Copy link
Member

liggitt commented Jun 21, 2017

the revert LGTM

I look forward to getting this in in 1.8

@liggitt liggitt added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 21, 2017
@liggitt
Copy link
Member

liggitt commented Jun 21, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2017
@liggitt
Copy link
Member

liggitt commented Jun 21, 2017 •
edited

cc @smarterclayton @saad-ali as original PR assignees

@smarterclayton
Copy link
Contributor

/approve

for reverting. This prevents us from shipping a beta API that we do not believe will be extensible in the future and while this would be valuable for 1.7.1, the risk of future lock in is too high.

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jhorwit2, liggitt, smarterclayton

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2017
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47851, 47824, 47858, 46099)

@k8s-github-robot k8s-github-robot merged commit 5d30190 into kubernetes:master Jun 21, 2017
@php-coder php-coder mentioned this pull request Jul 20, 2017
Merged
@jhorwit2 jhorwit2 mentioned this pull request Aug 6, 2017
Merged
jianhuiz pushed a commit to jianhuiz/kubernetes that referenced this pull request Sep 1, 2017
Merge pull request kubernetes#50212 from jhorwit2/jah/psp-hostpath
3937783 
Automatic merge from submit-queue (batch tested with PRs 50719, 51216, 50212, 51408, 51381)

Allow PSP's to specify a whitelist of allowed paths for host volume

**What this PR does / why we need it**:

Reverts the revert for the allowed host path feature that was moved from v1.7 to v1.8. This PR also changes the api as discussed in kubernetes#47811.

Original pr: kubernetes#43946
revert: kubernetes#47851

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes kubernetes#29326

**Special notes for your reviewer**:

cc @liggitt @ericchiang @php-coder 

It seems the api build process has changed. Hopefully I did it right 👼 .

**Release note**:

```release-note
Allow PSP's to specify a whitelist of allowed paths for host volume
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liggitt liggitt

@smarterclayton smarterclayton

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

structure of allowHostPaths in PodSecurityPolicy does not allow for future checks
9 participants
@jhorwit2 @k8s-ci-robot @liggitt @ericchiang @rootfs @smarterclayton @k8s-github-robot @erictune @saad-ali